Update pre-commit hook configuration for context-aware validation#17
Merged
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the pre-commit hook configuration to set pass_filenames: false.
Reasoning: The package-xml-validator needs to scan the entire package context (including CMakeLists.txt, launch files, and test directories) to accurately verify dependencies. If we passed specific filenames, the tool might miss context when only a secondary file (like a launch script) is modified. Setting pass_filenames: false ensures the tool always scans the full package structure for dependency synchronization. It also ensures the tool is not called multiple times in parallel.
Changes: